Option --disable-wmf writes image embed code for wmf/emf files, and fix for writing emf files.#73
Open
allefeld wants to merge 4 commits intossine:masterfrom
Open
Option --disable-wmf writes image embed code for wmf/emf files, and fix for writing emf files.#73allefeld wants to merge 4 commits intossine:masterfrom
allefeld wants to merge 4 commits intossine:masterfrom
Conversation
|
bump |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pptx2mdhas an option--disable-wmf, which however has no effect. The first commit is my (minimal) implementation, where the option leads to image embed code () to be written to the output.While there is to my knowledge no Markdown implementation which can actually embed WMF files, this serves as a placeholder to inform the user where the image is supposed to go. For my use, I will convert WMF files to SVG files using Inkscape and embed those, which works well with RevealJS output from Quarto.
After implementing the above, I noticed that the wmf files written by pptx2md cannot be read by Inkscape, because the file content is actually EMF (enhanced metafile). Apparently
python-pptxhas a bug (?) whereshape.image.extiswmfwhen it should beemf. In case of the PowerPoint file I worked with, the correct extension is inshape.image.filename. The second commit contains a fix based on that observation.